Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

relay/syncer: relay notifies syncer of new write to reduce sync latency (#2225) #2269

Closed
wants to merge 1 commit into from
Closed

relay/syncer: relay notifies syncer of new write to reduce sync latency (#2225) #2269

wants to merge 1 commit into from

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2225

What problem does this PR solve?

What is changed and how it works?

  • add Listener function to relay, it notifies after writing events successfully
  • add EventNotifier to local binlog reader(used by syncer), and change polling file change to waiting on write events to reduce sync latency

Check List

Tests

  • Unit test

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 27, 2021
Merged
@ti-chi-bot ti-chi-bot added contribution For contributor needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated size/XXL type/cherry-pick-for-release-2.0 labels Oct 27, 2021
@Ehco1996
Copy link
Contributor

no need to cherry pick

@Ehco1996 Ehco1996 closed this Oct 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lance6716 lance6716 Awaiting requested review from lance6716

@lichunzhu lichunzhu Awaiting requested review from lichunzhu

Assignees
No one assigned
Labels
contribution For contributor needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated size/XXL type/cherry-pick-for-release-2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @Ehco1996 @D3Hunter